From bea36d65a076a5ba2c5b849e6b12edafb68f63f4 Mon Sep 17 00:00:00 2001
From: Timothy Carambat <rambat1010@gmail.com>
Date: Sat, 18 May 2024 21:30:33 -0700
Subject: [PATCH] General Workspace settings UI updates (#1452)

General Workspace settings updates 05/17
- Move vector count to vector database
- Modify hint on LLM Temperature
---
 .../ChatSettings/ChatTemperatureSettings/index.jsx | 14 +++++++++-----
 .../WorkspaceSettings/GeneralAppearance/index.jsx  |  2 --
 .../VectorCount/index.jsx                          |  3 ---
 .../WorkspaceSettings/VectorDatabase/index.jsx     |  6 +++++-
 4 files changed, 14 insertions(+), 11 deletions(-)
 rename frontend/src/pages/WorkspaceSettings/{GeneralAppearance => VectorDatabase}/VectorCount/index.jsx (88%)

diff --git a/frontend/src/pages/WorkspaceSettings/ChatSettings/ChatTemperatureSettings/index.jsx b/frontend/src/pages/WorkspaceSettings/ChatSettings/ChatTemperatureSettings/index.jsx
index 5cbcdc3b..08565f58 100644
--- a/frontend/src/pages/WorkspaceSettings/ChatSettings/ChatTemperatureSettings/index.jsx
+++ b/frontend/src/pages/WorkspaceSettings/ChatSettings/ChatTemperatureSettings/index.jsx
@@ -20,19 +20,23 @@ export default function ChatTemperatureSettings({
           LLM Temperature
         </label>
         <p className="text-white text-opacity-60 text-xs font-medium py-1.5">
-          This setting controls how &quot;random&quot; or dynamic your chat
-          responses will be.
+          This setting controls how &quot;creative&quot; your LLM responses will
+          be.
           <br />
-          The higher the number (1.0 maximum) the more random and incoherent.
+          The higher the number the more creative. For some models this can lead
+          to incoherent responses when set too high.
           <br />
-          <i>Recommended: {defaults.temp}</i>
+          <br />
+          <i>
+            Most LLMs have various acceptable ranges of valid values. Consult
+            your LLM provider for that information.
+          </i>
         </p>
       </div>
       <input
         name="openAiTemp"
         type="number"
         min={0.0}
-        max={1.0}
         step={0.1}
         onWheel={(e) => e.target.blur()}
         defaultValue={workspace?.openAiTemp ?? defaults.temp}
diff --git a/frontend/src/pages/WorkspaceSettings/GeneralAppearance/index.jsx b/frontend/src/pages/WorkspaceSettings/GeneralAppearance/index.jsx
index 5e4053f0..101a3a9b 100644
--- a/frontend/src/pages/WorkspaceSettings/GeneralAppearance/index.jsx
+++ b/frontend/src/pages/WorkspaceSettings/GeneralAppearance/index.jsx
@@ -2,7 +2,6 @@ import Workspace from "@/models/workspace";
 import { castToType } from "@/utils/types";
 import showToast from "@/utils/toast";
 import { useEffect, useRef, useState } from "react";
-import VectorCount from "./VectorCount";
 import WorkspaceName from "./WorkspaceName";
 import SuggestedChatMessages from "./SuggestedChatMessages";
 import DeleteWorkspace from "./DeleteWorkspace";
@@ -51,7 +50,6 @@ export default function GeneralInfo({ slug }) {
         onSubmit={handleUpdate}
         className="w-1/2 flex flex-col gap-y-6"
       >
-        <VectorCount reload={true} workspace={workspace} />
         <WorkspaceName
           key={workspace.slug}
           workspace={workspace}
diff --git a/frontend/src/pages/WorkspaceSettings/GeneralAppearance/VectorCount/index.jsx b/frontend/src/pages/WorkspaceSettings/VectorDatabase/VectorCount/index.jsx
similarity index 88%
rename from frontend/src/pages/WorkspaceSettings/GeneralAppearance/VectorCount/index.jsx
rename to frontend/src/pages/WorkspaceSettings/VectorDatabase/VectorCount/index.jsx
index 9a882875..173acf8e 100644
--- a/frontend/src/pages/WorkspaceSettings/GeneralAppearance/VectorCount/index.jsx
+++ b/frontend/src/pages/WorkspaceSettings/VectorDatabase/VectorCount/index.jsx
@@ -28,9 +28,6 @@ export default function VectorCount({ reload, workspace }) {
   return (
     <div>
       <h3 className="input-label">Number of vectors</h3>
-      <p className="text-white text-opacity-60 text-xs font-medium py-1">
-        Total number of vectors in your vector database.
-      </p>
       <p className="text-white text-opacity-60 text-sm font-medium">
         {totalVectors}
       </p>
diff --git a/frontend/src/pages/WorkspaceSettings/VectorDatabase/index.jsx b/frontend/src/pages/WorkspaceSettings/VectorDatabase/index.jsx
index 0a9a0e87..97d63291 100644
--- a/frontend/src/pages/WorkspaceSettings/VectorDatabase/index.jsx
+++ b/frontend/src/pages/WorkspaceSettings/VectorDatabase/index.jsx
@@ -6,6 +6,7 @@ import VectorDBIdentifier from "./VectorDBIdentifier";
 import MaxContextSnippets from "./MaxContextSnippets";
 import DocumentSimilarityThreshold from "./DocumentSimilarityThreshold";
 import ResetDatabase from "./ResetDatabase";
+import VectorCount from "./VectorCount";
 
 export default function VectorDatabase({ workspace }) {
   const [hasChanges, setHasChanges] = useState(false);
@@ -38,7 +39,10 @@ export default function VectorDatabase({ workspace }) {
       onSubmit={handleUpdate}
       className="w-1/2 flex flex-col gap-y-6"
     >
-      <VectorDBIdentifier workspace={workspace} />
+      <div className="flex items-start gap-x-5">
+        <VectorDBIdentifier workspace={workspace} />
+        <VectorCount reload={true} workspace={workspace} />
+      </div>
       <MaxContextSnippets workspace={workspace} setHasChanges={setHasChanges} />
       <DocumentSimilarityThreshold
         workspace={workspace}